Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rollout Adapter for importing rollout data into Flipper #319
Adds an adapter to import Rollout data into Flipper
Rollout supports the equivalent to Flipper's
Rollout does not support
Importing only requires
SWEEEEEEEET. I love this so much, mostly because it shows the flexibility and removes a tiny road block for switching if someone is interested. I really appreciate that you took the time to both implement this and explain all the trade-offs. Well done!
for the methods the adapter doesn't implement I'm thinking of raising an error similar to the read only adapter to make it clear that this adapter is only for importing since rollout doesn't have feature parity
I do like the more thorough test.
I like it too.
this will only work with rollout ~> 2.0 because the Rollout public api changed from 1 -> 2 and this is reflected in the gemspec dependency.
Something we can document easily enough.
Rollout 2.3 introduced casting percentages to_f before saving. For flipper users using Flipper < 0.11 (before Flipper supported decimal percentages) the values between Rollout (decimal) and Flipper(integer) would be different, although I don't think this is a big deal?
Probably not a big deal. We can add it as a caveat on the rollout docs and tell people to make sure they are running >= 0.11
users importing Rollout data would need to reregister their groups since those are an evaluated block in memory
Yep, great point. Seems totally fine to document this as well.
@jnunemaker I'll open another issue to document this and hopefully get to that this week
I think its all good to release new version then get docs up. I'd say 0.12 would be the correct semver since as you mention its an addition and not a bugfix, but 0.11.1 is cool too.