New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow feature removal from the UI to be disabled #322

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
2 participants
@mateusg
Contributor

mateusg commented Jan 4, 2018

This change allows the Danger Zone + Delete Feature button to be removed from the Flipper UI.

I thought it was a good idea do have it, because sometimes adding or removing features is a job for developers only, who might want to do it only via console, rake tasks, migrations or seeds.

What do you guys think?

@jnunemaker

Sweet! Thanks. I see no problem with this. Thanks for adding. I would like to move this into the Flipper::UI::Configuration code but the feature_creation_enabled needs to go there to so I'll make a new issues for that.

@@ -24,14 +24,19 @@ class << self
# Public: Is feature creation allowed from the UI? Defaults to true. If
# set to false, users of the UI cannot create features. All feature
# creation will need to be done through the conigured flipper instance.
# creation will need to be done through the configured flipper instance.

This comment has been minimized.

@jnunemaker

jnunemaker Jan 6, 2018

Owner

Nice! Thanks.

@jnunemaker jnunemaker merged commit 365aee6 into jnunemaker:master Jan 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mateusg mateusg deleted the mateusg:ui-feature-removal-disabling branch Jan 7, 2018

@mateusg

This comment has been minimized.

Contributor

mateusg commented Jan 8, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment