Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow feature removal from the UI to be disabled #322

Merged
merged 1 commit into from Jan 6, 2018

Conversation

@mateusg
Copy link
Contributor

@mateusg mateusg commented Jan 4, 2018

This change allows the Danger Zone + Delete Feature button to be removed from the Flipper UI.

I thought it was a good idea do have it, because sometimes adding or removing features is a job for developers only, who might want to do it only via console, rake tasks, migrations or seeds.

What do you guys think?

Copy link
Owner

@jnunemaker jnunemaker left a comment

Sweet! Thanks. I see no problem with this. Thanks for adding. I would like to move this into the Flipper::UI::Configuration code but the feature_creation_enabled needs to go there to so I'll make a new issues for that.

Loading

@@ -24,14 +24,19 @@ class << self

# Public: Is feature creation allowed from the UI? Defaults to true. If
# set to false, users of the UI cannot create features. All feature
# creation will need to be done through the conigured flipper instance.
# creation will need to be done through the configured flipper instance.
Copy link
Owner

@jnunemaker jnunemaker Jan 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

Loading

@jnunemaker jnunemaker merged commit 365aee6 into jnunemaker:master Jan 6, 2018
1 check passed
Loading
@mateusg mateusg deleted the ui-feature-removal-disabling branch Jan 7, 2018
@mateusg
Copy link
Contributor Author

@mateusg mateusg commented Jan 8, 2018

👍

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants