Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Cache Key Fix #325

Merged
merged 3 commits into from Jan 6, 2018
Merged

Redis Cache Key Fix #325

merged 3 commits into from Jan 6, 2018

Conversation

@jnunemaker
Copy link
Owner

@jnunemaker jnunemaker commented Jan 6, 2018

Problem described in #323 (comment).

  • added spec to show that it failed to cache for the intended cache key
  • added code change to use the correct cache key
jnunemaker added 3 commits Jan 6, 2018
Described in
#323 (comment).
key made me think feature key which made me incorrectly use key_for.
This is a fully qualified cache_key, not a feature key. Maybe this will
stop me from doing something stupid in the future (in addition the spec
added in commit a few commits back).
@jnunemaker jnunemaker self-assigned this Jan 6, 2018
@jnunemaker jnunemaker merged commit 81a3ed3 into master Jan 6, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jnunemaker jnunemaker deleted the redis-cache-fix branch Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.