New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Record get_all Fix #327

Merged
merged 4 commits into from Jan 7, 2018

Conversation

Projects
None yet
1 participant
@jnunemaker
Owner

jnunemaker commented Jan 6, 2018

Fixes the sequel and active record adapters to include even disabled features in get_all. The issue was using an inner join between feature and gate tables, which means features in the feature table but not in the gate table (because they were fully disabled) were not represented in get_all.

fixes #324

jnunemaker added some commits Jan 6, 2018

@jnunemaker jnunemaker added the bug label Jan 6, 2018

@jnunemaker jnunemaker self-assigned this Jan 6, 2018

@jnunemaker

This comment has been minimized.

Owner

jnunemaker commented Jan 6, 2018

I think I should probably make this an adapter shared spec/test so we can catch this for all of them.

@jnunemaker

This comment has been minimized.

Owner

jnunemaker commented Jan 6, 2018

The sequel adapter also has this problem. I'll move this to a shared test/spec for all adapters and then merge it.

jnunemaker added some commits Jan 7, 2018

Use model table_name instead of explicit table name
In case anyone renamed a table for whatever reason.

@jnunemaker jnunemaker merged commit 5026e12 into master Jan 7, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jnunemaker jnunemaker deleted the get_all_fix branch Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment