Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove YouTube embed from default landing #384

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@cbartlett
Copy link

commented Nov 20, 2018

I find the default landing page frustratingly unprofessional. You can call me unfunny if you want, but I always need to ensure I add some features in every environment, lest I get strange looks and comments from my clients.

Am I the only one who thinks we should just keep this page simple and meme-free?

screen shot 2018-11-20 at 7 26 51 am

@jnunemaker

This comment has been minimized.

Copy link
Owner

commented Dec 10, 2018

I can see that. Could I talk you into adding a config option for this to Flipper::UI config? Perhaps config.taylor_swift = true/false and default it to true?

@jnunemaker

This comment has been minimized.

Copy link
Owner

commented Dec 10, 2018

Or... config.fun, config.business_time, or config.professional, etc. :)

@nachokb nachokb referenced this pull request Jan 25, 2019

Closed

remove Taylor Swift joke #398

@jcraigk

This comment has been minimized.

Copy link

commented Jan 30, 2019

I support this PR. This is getting to be a mature gem used by a lot of folks, and I feel it has probably outgrown the whimsical nature of the YouTube embed. I appreciate the fun intent, but I think the OP makes a valid overriding point.

@jnunemaker

This comment has been minimized.

Copy link
Owner

commented Feb 7, 2019

I have a history of maintaining whimsicality long into maturity with gems, so I'll be leaving this. Happy to have a config option. Closing this to keep things tidy, but if anyone wants to open a new one with config option or update this one, I'd be happy to merge.

@jnunemaker jnunemaker closed this Feb 7, 2019

@jcraigk

This comment has been minimized.

Copy link

commented Feb 7, 2019

Ah, I didn't realize you maintain HTTParty as well. That rather unusual (inappropriate?) use of the post-install message "you must party hard" (https://github.com/jnunemaker/httparty/blob/master/httparty.gemspec#L22) makes more sense to me now. Your gems, your call :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.