Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added URI::Generic to supported URL schemes #164

Merged
merged 1 commit into from Jan 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

allspiritseve commented Sep 17, 2012

Resolves issue #163

Owner

jnunemaker commented Sep 18, 2012

Got a failing test still.

This test needs to be updated.

I believe the issue is that the test expects an unsupported URI error, but since the url is part of URI::Generic, that error isn't raised.

I'd fix it myself, but I'm not sure what the best way to fix it would be.

Contributor

allspiritseve commented Oct 31, 2012

Sorry for the delay, I removed the failing spec since it was no longer relevant, and added a passing spec for webcal.

jnunemaker added a commit that referenced this pull request Jan 1, 2013

Merge pull request #164 from allspiritseve/master
Added URI::Generic to supported URL schemes

@jnunemaker jnunemaker merged commit 4bcf581 into jnunemaker:master Jan 1, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment