Add default option on head requests#430
Conversation
|
I'm not comfortable merging without a passing spec and I don't have time to look into this right now. If someone else could help, that would be great. |
|
Okay, I had some more time and was able to refactor this a bit to make it more easily testable, then add specs. I went with the "principle of least surprise" approach outlined by xunker, ensuring that head requests maintain the HEAD method across all redirects, unless the user specifies |
There was a problem hiding this comment.
This means it will do a GET if it is set to false, is that right?
There was a problem hiding this comment.
Exactly. I wanted to make sure there was still a way to override the new behavior, in case someone wanted to do that.
…ects Add default option on head requests
|
@supremebeing7 Thanks for taking care of this, I'm glad my research was helpful to you. 👍 |
|
@xunker Very helpful 🎉 |
This attempts to resolve #345. I'm pretty confident the code works, but I couldn't get the spec figured out. I left my attempt in there, with the expectation line commented out.
Suggestions welcome/encouraged.