Use MultiJson and MultiXml for parsing instead of Crack #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
+1 for sure |
|
+1 |
|
This is sorely needed. Crack chokes on some valid responses that the stdlib JSON handles correctly. One such example is here: #75 |
|
+1 Before applying this patch, I got all kinds of encoding errors while using the Google Translate API. With this patch applied, no issues any more. Either this one or: |
|
+1 |
|
+1 from me, too. I'm seeing similar issues with HTTParty 0.1.8 and Ruby 1.9.2-p290 giving the |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
Fantastic! Everything is working better than expected now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've switched the parser to use MultiJson and MultiXml, which automatically chooses the best option from what is installed, or optionally what is explicitly specified, allowing the use of Yajl or nokogiri or what have you instead of requiring parsing be done with Crack.