Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't define .name on Joint module #16

Merged
merged 1 commit into from Mar 11, 2013

Conversation

Projects
None yet
2 participants
Contributor

plusplus commented Jul 10, 2012

Hey.. I hit a problem using Joint with @avdi's display_case gem.

It's accessing the name of classes like this: object.class.ancestors.map {|c| c.name}, which caused problems with the definition of self.name on the Joint active concern (as it takes a parameter).

All I've done here is move the utility methods like self.name and self.type and self.size to their own module.

It may well make sense to rename the .name method as well, as it's probably bad form.

Cheers, and thanks for all your awesome open source software!

Moved joint file helpers into their own module to avoid problem where…
… other classes were trying to use the name property of a class like this: object.class.ancestors.map {|c| c.name}

jnunemaker added a commit that referenced this pull request Mar 11, 2013

Merge pull request #16 from plusplus/master
Don't define .name on Joint module

@jnunemaker jnunemaker merged commit 4abeb76 into jnunemaker:master Mar 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment