Skip to content

John Nunemaker
jnunemaker

Organizations

@github
jnunemaker commented on pull request jnunemaker/flipper#102
@jnunemaker

I appreciate the idea, but I personally don't want to confirm every click. I wonder if we could allow setting the environment in config somewhere a…

jnunemaker commented on issue jnunemaker/flipper#101
@jnunemaker

We do the same at GitHub. Seems like a good idea. I haven't thought through how it would work or where it would go, but a PR would definitely activ…

@jnunemaker
  • @jnunemaker 702f41f
    A few more updates to bring laptops in sync
@jnunemaker
  • @jnunemaker 1bd1609
    Several updates to local setup before switching laptops
@jnunemaker
@jnunemaker
@jnunemaker
jnunemaker merged pull request jnunemaker/flipper#100
@jnunemaker
Fix uninitialized constant Flipper::Rails::Generators
1 commit with 2 additions and 2 deletions
@jnunemaker
jnunemaker merged pull request jnunemaker/httparty#462
@jnunemaker
Upgrade RSpec to 3.4 and Cucumber to 2.3
1 commit with 2 additions and 2 deletions
jnunemaker commented on pull request jnunemaker/httparty#461
@jnunemaker

Thanks!

@jnunemaker
jnunemaker merged pull request jnunemaker/httparty#461
@jnunemaker
Add Ruby 2.3 to Travis matrix
1 commit with 4 additions and 3 deletions
jnunemaker commented on pull request jnunemaker/httparty#461
@jnunemaker

So it seems that if you specify the patch version rvm can find and install Ruby 2.3.0. Seems fine to me. I guess only downside is it won't upgrad…

@jnunemaker
jnunemaker merged pull request jnunemaker/httparty#460
@jnunemaker
Use reject instead of delete_if to prevent mutation
1 commit with 18 additions and 1 deletion
jnunemaker commented on pull request jnunemaker/httparty#461
@jnunemaker

I noticed this on a different project (that 2.3 isn't there). I don't really care how it works. If you know of another way to make 2.3 work, I'm op…

jnunemaker commented on issue jnunemaker/flipper#99
@jnunemaker

Could you add some logging to get some more information? Check to see which of the conditionals is returning false maybe (ie: request ip or current…

jnunemaker commented on issue jnunemaker/httparty#459
@jnunemaker

That is really odd. I'm open to a PR that fixes it. Thanks for filing.

@jnunemaker

Also hitting this.

jnunemaker commented on issue jnunemaker/httparty#225
@jnunemaker

If you're not willing to even look at it, I'm not going to be able to justify spending any more time. Also, I am and have been looking at everyth…

jnunemaker commented on issue jnunemaker/httparty#225
@jnunemaker

I still don't understand how your example is testing the condition of the server returning a blank body. Yeah, it might not be. I think I misunde…

jnunemaker commented on issue jnunemaker/httparty#225
@jnunemaker

@aceofspades I don't trust webmock and those. I want to see an actual httparty call against an actual service so I can avoid an rabbit holes. I don…

jnunemaker commented on pull request jnunemaker/httparty#458
@jnunemaker

I do releases after a week or two or a few changes go in. In general, I try to avoid doing a release for each PR. If you want to use the code right…

@jnunemaker
jnunemaker merged pull request jnunemaker/httparty#458
@jnunemaker
Logs 'base_uri' and query at Logger::CurlFormatter
1 commit with 167 additions and 23 deletions
jnunemaker commented on pull request caskroom/homebrew-cask#17251
@jnunemaker

Also, thanks! Sorry I forgot to say that. Appreciate the help.

jnunemaker commented on pull request caskroom/homebrew-cask#17251
@jnunemaker

That worked. Seems like there should be a more helpful error message when running the command that says something about an update being needed or s…

Something went wrong with that request. Please try again.