feat: add metrics for request length and response length#48
Conversation
|
@joao-fontenele Could you take a look this PR? |
There was a problem hiding this comment.
Hello @matsumana
These are nice to have metrics, The only problem I see with this is making collecting it mandatory. If you make these changes optional, It would be good to merge
|
Thank you for reviewing. |
|
@joao-fontenele Could you take a look this again? |
|
@joao-fontenele I am sorry to bother you. Could you take a look this again? |
|
@matsumana there's a conflict with master, if you resolve the conflicts I can merge it |
|
@joao-fontenele I could not find any conflicts.
|
|
yep, my bad I was selecting the option to rebase and merge, and was seeing a conflict, but it's actually updated |
|
Thank you for reviewing. |
|
@matsumana sorry for the delay, man, and thanks for the contribution. Already released the new version |
|
Thank you so much! |
Hi,
I would like to add the new metrics for Request length and Response length.
Motivation:
If an API handles a large JSON in request or response, the latency might get worse.
So I would like to monitor them.