New snippet with selected text #309

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@songjie-dong
Contributor

songjie-dong commented Sep 25, 2012

No description provided.

@joaotavora joaotavora closed this Nov 9, 2012

@songjie-dong

This comment has been minimized.

Show comment Hide comment
@songjie-dong

songjie-dong Nov 10, 2012

Contributor

Sorry about no description.

This patch is not a snippet, but used in the following scene:

  1. recently entered the code suitable for use as snippets
  2. select code
  3. C-c & C-n to add new snippet
  4. new snippet's buffer contain those code
  5. modify and save new snippet

A optimization for new snippet action.

Contributor

songjie-dong commented Nov 10, 2012

Sorry about no description.

This patch is not a snippet, but used in the following scene:

  1. recently entered the code suitable for use as snippets
  2. select code
  3. C-c & C-n to add new snippet
  4. new snippet's buffer contain those code
  5. modify and save new snippet

A optimization for new snippet action.

@joaotavora

This comment has been minimized.

Show comment Hide comment
@joaotavora

joaotavora Nov 11, 2012

Owner

Ah ok, I'll reopen this and have a look when I find the time. thanks for the description.

Owner

joaotavora commented Nov 11, 2012

Ah ok, I'll reopen this and have a look when I find the time. thanks for the description.

@joaotavora joaotavora reopened this Nov 11, 2012

@lewang

This comment has been minimized.

Show comment Hide comment
@lewang

lewang Nov 21, 2012

Contributor

@songjie-dong Please add your description to the actual git commit messages. Github may not be around with this project forever, it's important to have meaningful commit messages.

Contributor

lewang commented Nov 21, 2012

@songjie-dong Please add your description to the actual git commit messages. Github may not be around with this project forever, it's important to have meaningful commit messages.

A optimization for new snippet action,used in the following scene:
1. recently entered the code suitable for use as snippets
2. select code
3. C-c & C-n to add new snippet
4. new snippet's buffer contain those code
5. modify and save new snippet
@songjie-dong

This comment has been minimized.

Show comment Hide comment
@songjie-dong

songjie-dong Nov 22, 2012

Contributor

I've already added comment, @lewang thanks for your reminding.

Contributor

songjie-dong commented Nov 22, 2012

I've already added comment, @lewang thanks for your reminding.

@npostavs

This comment has been minimized.

Show comment Hide comment
@npostavs

npostavs May 15, 2016

Collaborator

I've rebased this as #698.

Collaborator

npostavs commented May 15, 2016

I've rebased this as #698.

@npostavs npostavs closed this in #698 Jun 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment