Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

optimize #13

wants to merge 1 commit into from

Conversation

p2world
Copy link

@p2world p2world commented Sep 7, 2017

No description provided.

@benatkin
Copy link

benatkin commented May 8, 2018

The RegExp /[_-+]/g is invalid, and needs to be changed to /[_\-+]/g. I got the error when setting up a jsperf, and I see the same error in the Travis CI job log:

/home/travis/build/joaquimserafim/base64-url/index.js:12:23: Parsing error: Error parsing regular expression: Invalid regular expression: /[_-+]/: Range out of order in character class

Also I wasn't sure it was faster, but it is according to this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p2world @benatkin