Skip to content

Revert #847 ? #965

Closed
Closed

Description

@cgohlke

Please consider reverting #847 (FIX python-lz4 version comparison)

Importing pkg_resources is known to be excruciatingly slow. See pypa/setuptools#510

On my Windows workstation, import pkg_resources takes more than 3 s.

Also, I can't reproduce that The python-lz4 package has its version string prefixed with "v":

>>> import lz4
>>> lz4.__version__
'2.2.1'
>>> from distutils.version import LooseVersion
>>> LooseVersion(lz4.__version__)
LooseVersion ('2.2.1')

Activity

  1. ogrisel commented on Dec 6, 2019

    @ogrisel
    Contributor

    Indeed I was not aware of this. We need to revert but also add a special handling of the "v" prefix in the version number of python-lz4.

  2. ogrisel commented on Dec 10, 2019

    @ogrisel
    Contributor

    @cgohlke joblib 0.14.1 is out with a fix for this regression. Thanks for the report.

  3. cgohlke commented on Dec 10, 2019

    @cgohlke
    Author

    Thank you!

  4. added a commit that references this issue on Dec 14, 2019
  5. added a commit that references this issue on May 11, 2026
  6. added a commit that references this issue on May 13, 2026
  7. added a commit that references this issue on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions