Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test child raises parent exits cleanly more reliable on macos #1335


Copy link

@ogrisel ogrisel commented Sep 14, 2022

This tests tends to fail randomly on the macos CI where os.path.exists seems to not be reliable even after 100 attempts spanning 10s.

As an alternative, try to write into the temp folder to check for its existence so as to force any FS-level cache invalidation.

@ogrisel ogrisel force-pushed the test_child_raises_parent_exits_cleanly-more-reliable-on-macos branch from 88dd0a5 to 1e32cbf Compare September 14, 2022 20:45
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 93.97% // Head: 94.06% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (8daadbc) compared to base (ac09691).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1335      +/-   ##
+ Coverage   93.97%   94.06%   +0.08%     
  Files          52       52              
  Lines        7303     7294       -9     
- Hits         6863     6861       -2     
+ Misses        440      433       -7     
Impacted Files Coverage Δ
joblib/test/ 99.23% <ø> (-0.02%) ⬇️
joblib/ 96.82% <0.00%> (+0.52%) ⬆️
joblib/test/ 97.14% <0.00%> (+5.71%) ⬆️
joblib/test/ 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

ogrisel commented Sep 14, 2022

I reported the test failure on the windows host upstream: joblib/loky#368

Copy link
Contributor Author

ogrisel commented Sep 15, 2022

I opened an joblib/loky#369 upstream for the test_nested_loop_error_in_grandchild_resource_tracker_silent failure.

Copy link
Contributor Author

ogrisel commented Sep 15, 2022

Let's move the test itself to loky.

@ogrisel ogrisel merged commit a23427d into joblib:master Sep 15, 2022
13 of 17 checks passed
@ogrisel ogrisel deleted the test_child_raises_parent_exits_cleanly-more-reliable-on-macos branch September 15, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant