Test child raises parent exits cleanly more reliable on macos #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
force-pushed
the
test_child_raises_parent_exits_cleanly-more-reliable-on-macos
branch
from
88dd0a5
to
1e32cbf
Compare
Codecov ReportBase: 93.97% // Head: 94.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
+ Coverage 93.97% 94.06% +0.08%
==========================================
Files 52 52
Lines 7303 7294 -9
==========================================
- Hits 6863 6861 -2
+ Misses 440 433 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I reported the test failure on the windows host upstream: joblib/loky#368 |
|
I opened an joblib/loky#369 upstream for the |
|
Let's move the test itself to loky. |
ogrisel
deleted the
test_child_raises_parent_exits_cleanly-more-reliable-on-macos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests tends to fail randomly on the macos CI where
os.path.existsseems to not be reliable even after 100 attempts spanning 10s.As an alternative, try to write into the temp folder to check for its existence so as to force any FS-level cache invalidation.