Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT add back pytest warnings plugin #1337

merged 2 commits into from Sep 15, 2022


Copy link

@lesteve lesteve commented Sep 15, 2022

It was removed in #525, not sure whether this is still needed. At least locally the test pass on my machine with the changes in my PR.

Context: I was trying to trigger warnings due to pytest.warns(None) and pytest 7 and could not see them.

Probably it would be good to get the pytest.warns(None) replacement from #1264

Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 93.99% // Head: 93.96% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (f497585) compared to base (a23427d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1337      +/-   ##
- Coverage   93.99%   93.96%   -0.03%     
  Files          52       52              
  Lines        7294     7294              
- Hits         6856     6854       -2     
- Misses        438      440       +2     
Impacted Files Coverage Δ
joblib/ 96.29% <0.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

ogrisel commented Sep 15, 2022

I agree we should report and progressively fix joblib to avoid triggering those warnings in the first place instead of hiding problems under the rug.

The random failures on macos have already been observed numerous times and are unrelated.

@ogrisel ogrisel merged commit ac4ebd5 into joblib:master Sep 15, 2022
13 of 15 checks passed
Copy link

ogrisel commented Sep 15, 2022

@lesteve feel free to takeover #1264 to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants