Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFAIL test_child_raises_parent_exits_cleanly with multiprocessing #1339

merged 2 commits into from Sep 15, 2022


Copy link

@ogrisel ogrisel commented Sep 15, 2022

Apparently this flaky test only fails for the non-default multiprocessing backend. While it would be nice to find a way to fix it, it seems particularly difficult to investigate.

Let's mark it as XFAIL for now while referencing the existing open issue #1086.

Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 94.00% // Head: 93.94% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (b394deb) compared to base (ac4ebd5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1339      +/-   ##
- Coverage   94.00%   93.94%   -0.07%     
  Files          52       52              
  Lines        7294     7294              
- Hits         6857     6852       -5     
- Misses        437      442       +5     
Impacted Files Coverage Δ
joblib/test/ 99.23% <100.00%> (ø)
joblib/test/ 50.00% <0.00%> (-50.00%) ⬇️
joblib/ 93.01% <0.00%> (-1.84%) ⬇️
joblib/ 96.56% <0.00%> (+0.26%) ⬆️
joblib/test/ 97.14% <0.00%> (+5.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogrisel ogrisel merged commit 067ed4f into joblib:master Sep 15, 2022
15 checks passed
@ogrisel ogrisel deleted the test_child_raises_parent_exits_cleanly branch September 15, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant