Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT cleanup numpy warnings related to np.matrix in tests #1340

merged 1 commit into from Sep 16, 2022


Copy link

@ogrisel ogrisel commented Sep 16, 2022

There still remain a few occurrences of np.matrix for the pickle compat tests. Cleaning those would require regenerating the stored pickled files with old Python & joblib versions.

We can do that in a later PR ;)

Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 93.96% // Head: 93.96% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8c8c33a) compared to base (cea26ff).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1340      +/-   ##
- Coverage   93.96%   93.96%   -0.01%     
  Files          52       52              
  Lines        7294     7292       -2     
- Hits         6854     6852       -2     
  Misses        440      440              
Impacted Files Coverage Δ
joblib/test/ 94.23% <80.00%> (+0.13%) ⬆️
joblib/ 95.25% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogrisel ogrisel merged commit 3fa2188 into joblib:master Sep 16, 2022
14 of 15 checks passed
@ogrisel ogrisel deleted the deprecated-numpy-matrix-in-tests branch September 16, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant