-
Notifications
You must be signed in to change notification settings - Fork 433
Move the metadata into pyproject.toml
#1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 94.01% // Head: 93.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
==========================================
- Coverage 94.01% 93.91% -0.10%
==========================================
Files 52 52
Lines 7300 7300
==========================================
- Hits 6863 6856 -7
- Misses 437 444 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a try and it seems to work as expected. Here are the commands I tried:
python setup.py bdist_wheel
python setup.py sdist
pip install -e .
python -m build # pep 517
I also tried to install the wheel and tarball generated by python -m build
in a new empty env and do basic joblib parallel calls and it works as expected.
"Programming Language :: Python :: 3.7", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we are at it:
"Programming Language :: Python :: 3.10", | |
"Programming Language :: Python :: 3.10", | |
"Programming Language :: Python :: 3.11", |
Hum I cannot accept my own suggestion, let merge and I will update the metadata later. |
Thanks @KOLANICH! |
No description provided.