-
Notifications
You must be signed in to change notification settings - Fork 431
BENCH add benchmark script for n_jobs=1 #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 94.09% // Head: 94.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
- Coverage 94.09% 94.04% -0.06%
==========================================
Files 52 52
Lines 7319 7319
==========================================
- Hits 6887 6883 -4
- Misses 432 436 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Add a benchmark script to test the overhead of calling
joblib
withn_jobs=1
vs calling a sequential loop fornumpy
matrix multiplications with various matrix sizes and for a very fast function (in red).This gives

here, we can see that for small tasks, we have an overhead of roughly x10 per task for tasks that takes 1ms.
This state should be corrected by the changes pushed in #588.