Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] deadlock between async dispatch and exception handling #296

Merged
merged 1 commit into from Jan 13, 2016

Conversation

@ogrisel
Copy link
Contributor

ogrisel commented Jan 13, 2016

This is a fix for a deadlock identified in #295.

@ogrisel

This comment has been minimized.

Copy link
Contributor Author

ogrisel commented Jan 13, 2016

Yes it works. @lesteve merge?

@ogrisel ogrisel added this to the 0.9.4 milestone Jan 13, 2016
@aabadie

This comment has been minimized.

Copy link
Contributor

aabadie commented Jan 13, 2016

LGTM. just curious, are you sure that removing the lock won't introduce other problems ?

@lesteve

This comment has been minimized.

Copy link
Member

lesteve commented Jan 13, 2016

LGTM. just curious, are you sure that removing the lock won't introduce other problems ?

That was the discussion we were having but it looks like @ogrisel is confident the lock wasn't necessary.

Let's merge this one then, thanks !

lesteve added a commit that referenced this pull request Jan 13, 2016
[MRG] deadlock between async dispatch and exception handling
@lesteve lesteve merged commit c60d263 into joblib:master Jan 13, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 88.525%
Details
@ogrisel

This comment has been minimized.

Copy link
Contributor Author

ogrisel commented Jan 13, 2016

LGTM. just curious, are you sure that removing the lock won't introduce other problems ?

I don't understand why I decided to use the lock there in the first place: we destroy the pool instance and therefore stop all its thread without waiting for them to complete.

ogrisel added a commit that referenced this pull request Jan 18, 2016
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Sep 30, 2016
* tag '0.9.4': (46 commits)
  Release 0.9.4
  DOC add missing changelog entry for joblib#296
  DOC add entry to changelog for joblib#294
  ENH spare one file descriptor / syscall in automemmap
  FIX auto-memmap gc bug by always hashing arrays
  TST non-regression test for auto-memmap / gc bug
  Add link to github issues for 0.9.4 changelog entries
  Fix my_exceptions._mk_exception when input exception is not inheritable
  add entry in changelog
  fixing hashing with mixed dtype + test
  Use _compat.PY3_OR_LATER where possible
  COSMIT fix some PEP8 horizontal misalignments
  Move definition of PY3_OR_LATER to _compat.py
  Do not use inspect.getargspec
  FIX joblib#295: deadlock between async dispatch and exception handling
  Add section in CHANGES.rst
  TRAVIS use numpy 1.10
  FIX style and pyflakes in test_pool.py
  Fix Parallel hanging with exhausted iterator
  remove useless section about versions of python prior to 2.6
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.