[MRG+1] Allow passing Path objects to joblib.{dump,load}. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -389,6 +393,8 @@ def dump(value, filename, compress=0, cache_size=100, protocol=None): | |||
| # By default, if compress is enabled, we want to be using 3 by | |||
| # default | |||
| compress = 3 | |||
| if Path and isinstance(filename, Path): | |||
There was a problem hiding this comment.
Nitpick: could you write this: "if Path is not None and isinstance(filename, Path)"
|
Beside the 2 nitpicks, that are just cosmetics to make the intent of the code more explicit, this is 👍 from me. Thank you very much! |
|
fixed |
GaelVaroquaux
changed the title
|
LGTM. + 1 for merge Can we have another review from the core team? |
|
|
Maybe a mention to this new feature could be added in CHANGES.rst.
+1 for CHANGES.rst. Thanks for spotting that!
|
|
Should I create a "0.9.5" entry? |
|
Should I create a "0.9.5" entry?
Yes, please
|
|
Done. |
|
LGTM, merging thanks ! |
lesteve
added a commit
that referenced
this pull request
Mar 7, 2016
[MRG+1] Allow passing Path objects to joblib.{dump,load}.
|
@anntzer FYI you can use "Fix #issue_number" in the PR description so that merging a PR closes automatically the associated issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #315.