Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Allow passing Path objects to joblib.{dump,load}. #316

Merged
merged 1 commit into from Mar 7, 2016
Merged

[MRG+1] Allow passing Path objects to joblib.{dump,load}. #316

merged 1 commit into from Mar 7, 2016

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 6, 2016

See #315.

@@ -389,6 +393,8 @@ def dump(value, filename, compress=0, cache_size=100, protocol=None):
# By default, if compress is enabled, we want to be using 3 by
# default
compress = 3
if Path and isinstance(filename, Path):
Copy link
Member

@GaelVaroquaux GaelVaroquaux Mar 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: could you write this: "if Path is not None and isinstance(filename, Path)"

@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Mar 6, 2016

Beside the 2 nitpicks, that are just cosmetics to make the intent of the code more explicit, this is 👍 from me. Thank you very much!

@anntzer
Copy link
Contributor Author

@anntzer anntzer commented Mar 6, 2016

fixed

@GaelVaroquaux GaelVaroquaux changed the title Allow passing Path objects to joblib.{dump,load}. [MRG+1] Allow passing Path objects to joblib.{dump,load}. Mar 6, 2016
@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Mar 6, 2016

LGTM. + 1 for merge

Can we have another review from the core team?

@aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 6, 2016

Can we have another review from the core team?
Just had a look, it seems all good to me as well. Maybe a mention to this new feature could be added in CHANGES.rst.

@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Mar 6, 2016

@anntzer
Copy link
Contributor Author

@anntzer anntzer commented Mar 7, 2016

Should I create a "0.9.5" entry?

@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Mar 7, 2016

@anntzer
Copy link
Contributor Author

@anntzer anntzer commented Mar 7, 2016

Done.

@lesteve
Copy link
Member

@lesteve lesteve commented Mar 7, 2016

LGTM, merging thanks !

lesteve added a commit that referenced this issue Mar 7, 2016
[MRG+1] Allow passing Path objects to joblib.{dump,load}.
@lesteve lesteve merged commit 81e1a71 into joblib:master Mar 7, 2016
2 checks passed
@lesteve
Copy link
Member

@lesteve lesteve commented Mar 7, 2016

@anntzer FYI you can use "Fix #issue_number" in the PR description so that merging a PR closes automatically the associated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants