New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Parallel backend parameters #325

Merged
merged 2 commits into from Mar 21, 2016

Conversation

Projects
None yet
2 participants
@ogrisel
Contributor

ogrisel commented Mar 18, 2016

This addresses @mrocklin's feature request in #322. It builds on top of #321.

@ogrisel ogrisel added the in progress label Mar 18, 2016

@mrocklin

This comment has been minimized.

Show comment
Hide comment
@mrocklin

mrocklin Mar 18, 2016

Contributor

This looks good to me

Contributor

mrocklin commented Mar 18, 2016

This looks good to me

@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Mar 18, 2016

Contributor

Fixed the style issue and amended my last commit. BTW this PR also makes it possible to pass a backend instance directly if you don't want to register it.

Contributor

ogrisel commented Mar 18, 2016

Fixed the style issue and amended my last commit. BTW this PR also makes it possible to pass a backend instance directly if you don't want to register it.

@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Mar 18, 2016

Contributor

Weird there was a seemingly unrelated travis failure in the python 3.4 without nunpy:

======================================================================
FAIL: joblib.test.test_memory.test_memory_warning_collision_detection(3, 2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda2/envs/testenv/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
nose.proxy.AssertionError: 3 != 2
    '3 != 2' = '%s != %s' % _common_shorten_repr(3, 2)
    '3 != 2' = self._formatMessage('3 != 2', '3 != 2')
>>  raise self.failureException('3 != 2')

@lesteve have you already seen this before? I will re-run that job to check whether it's deterministic or not.

Contributor

ogrisel commented Mar 18, 2016

Weird there was a seemingly unrelated travis failure in the python 3.4 without nunpy:

======================================================================
FAIL: joblib.test.test_memory.test_memory_warning_collision_detection(3, 2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda2/envs/testenv/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
nose.proxy.AssertionError: 3 != 2
    '3 != 2' = '%s != %s' % _common_shorten_repr(3, 2)
    '3 != 2' = self._formatMessage('3 != 2', '3 != 2')
>>  raise self.failureException('3 != 2')

@lesteve have you already seen this before? I will re-run that job to check whether it's deterministic or not.

@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Mar 18, 2016

Contributor

I created #326 to track the random failure I observed in this PR but that is not related to the change I made here.

Contributor

ogrisel commented Mar 18, 2016

I created #326 to track the random failure I observed in this PR but that is not related to the change I made here.

ogrisel added a commit that referenced this pull request Mar 21, 2016

Merge pull request #325 from ogrisel/parallel-backend-parameters
[MRG] Parallel backend parameters

@ogrisel ogrisel merged commit 0e52d38 into joblib:master Mar 21, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 88.804%
Details

@ogrisel ogrisel removed the in progress label Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment