[MRG+1] Fix format_stack with compiled code (e.g. .so or .pyd) in the traceback #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lesteve, in case you missed it, tests are broken on Travis under Python 3.3. |
lesteve
force-pushed
the
fix-format-stack-with-compiled-code
branch
2 times, most recently
from
9fe1751
to
2674adc
Compare
|
All green +1 |
aabadie
changed the title
|
I forgot to add a comment about the addition of SyntaxError in the code, I'll do that soonish. |
Ok, let me know when it's done. |
lesteve
force-pushed
the
fix-format-stack-with-compiled-code
branch
from
2674adc
to
18f7fad
Compare
lesteve
force-pushed
the
fix-format-stack-with-compiled-code
branch
from
18f7fad
to
90deace
Compare
|
@aabadie I added the aforementioned comment and an entry in CHANGES.rst. |
|
LGTM, merging. Thanks ! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Took the fix from IPython.core.ultratb.py