Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix format_stack with compiled code (e.g. .so or .pyd) in the traceback #382

Merged
merged 1 commit into from Aug 1, 2016

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jul 28, 2016

Fixes #101.

Took the fix from IPython.core.ultratb.py

@aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 28, 2016

@lesteve, in case you missed it, tests are broken on Travis under Python 3.3.

@lesteve lesteve force-pushed the fix-format-stack-with-compiled-code branch 2 times, most recently from 9fe1751 to 2674adc Compare Jul 29, 2016
@aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 29, 2016

All green +1

@aabadie aabadie changed the title [MRG] Fix format_stack with compiled code (e.g. .so or .pyd) in the traceback [MRG+1] Fix format_stack with compiled code (e.g. .so or .pyd) in the traceback Jul 29, 2016
@lesteve
Copy link
Member Author

@lesteve lesteve commented Jul 29, 2016

I forgot to add a comment about the addition of SyntaxError in the code, I'll do that soonish.

@aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 29, 2016

I forgot to add a comment about the addition of SyntaxError in the code, I'll do that soonish.

Ok, let me know when it's done.

@lesteve lesteve force-pushed the fix-format-stack-with-compiled-code branch from 2674adc to 18f7fad Compare Jul 29, 2016
@lesteve lesteve force-pushed the fix-format-stack-with-compiled-code branch from 18f7fad to 90deace Compare Jul 29, 2016
@lesteve
Copy link
Member Author

@lesteve lesteve commented Aug 1, 2016

@aabadie I added the aforementioned comment and an entry in CHANGES.rst.

@aabadie
Copy link
Contributor

@aabadie aabadie commented Aug 1, 2016

LGTM, merging. Thanks !

@aabadie aabadie merged commit 169dd49 into joblib:master Aug 1, 2016
3 checks passed
@lesteve lesteve deleted the fix-format-stack-with-compiled-code branch Aug 1, 2016
@amueller
Copy link
Contributor

@amueller amueller commented Aug 2, 2016

Awesome, thanks!
I'd love to have this in sklearn 0.8.
@ogrisel thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants