Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] turn warnings into error in the doc generation #504

Merged
merged 2 commits into from Mar 1, 2017

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Mar 1, 2017

  • ignore "nonlocal image URI found"
  • add doc generation in one of the Travis build

I had to fix a few warnings before the release and it would be great to do this incrementally on each PR instead.

and ignore "nonlocal image URI found".

Add doc generation in one of the Travis build.
@lesteve
Copy link
Member Author

lesteve commented Mar 1, 2017

This is just to make sure that the CIs pass and that Travis does generate the doc. I'll merge this when this is the case.

@codecov
Copy link

codecov bot commented Mar 1, 2017

Codecov Report

Merging #504 into master will increase coverage by 1.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   91.05%   92.92%   +1.86%     
==========================================
  Files          37       37              
  Lines        4764     4764              
==========================================
+ Hits         4338     4427      +89     
+ Misses        426      337      -89
Impacted Files Coverage Δ
joblib/logger.py 85.52% <0%> (+1.31%)
joblib/test/test_parallel.py 92.83% <0%> (+1.85%)
joblib/disk.py 80.39% <0%> (+1.96%)
joblib/test/test_numpy_pickle.py 99.04% <0%> (+2.68%)
joblib/backports.py 85.41% <0%> (+4.16%)
joblib/pool.py 90.32% <0%> (+7.25%)
joblib/test/test_pool.py 99.59% <0%> (+7.72%)
joblib/test/common.py 75% <0%> (+11.53%)
joblib/test/test_hashing.py 98.32% <0%> (+11.73%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffbb87...99ea07a. Read the comment docs.

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Mar 1, 2017 via email

@lesteve
Copy link
Member Author

lesteve commented Mar 1, 2017

Congratulations!

Not 100% sure what the congratulation is about. If this is about the coverage increase, I think that this is very likely bogus.

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Mar 1, 2017 via email

@lesteve lesteve merged commit b991399 into joblib:master Mar 1, 2017
@lesteve lesteve deleted the doc-warnings-into-error branch March 1, 2017 17:00
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Nov 3, 2017
* tag '0.11': (60 commits)
  Add configuration for readthedocs
  Minor fixes in CHANGES.rst
  Set relase version to 0.11
  Add 0.11 section to changelog
  Fix rst for correct rendering on PyPI
  MAINT update release instructions to use twine
  [MRG] Fix AppVeyor test exit code (joblib#505)
  [MRG] turn warnings into error in the doc generation (joblib#504)
  MAINT replace py.test by pytest
  MAINT remove most warnings from documentating the doc
  Shorter error message when cache results can not be loaded. (joblib#501)
  Replace deprecated logging.warn by logging.warning
  add pypi badge to readme and move the bagdes to the top (joblib#500)
  Enable codecov on AppVeyor (joblib#497)
  Improve folder organisation for CI files (joblib#499)
  Revert flake8 version to 2.5.1
  Use Python 3.5 on AppVeyor (joblib#495)
  Fix race condition in Memory when persisting output in parallel (joblib#491)
  WindowsError should be a type under non-Windows platforms (joblib#494)
  [MRG+1] activate coverage on multiple builds (joblib#493)
  ...
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Nov 3, 2017
* commit '0.11-7-g0d2e765': (60 commits)
  Add configuration for readthedocs
  Minor fixes in CHANGES.rst
  Set relase version to 0.11
  Add 0.11 section to changelog
  Fix rst for correct rendering on PyPI
  MAINT update release instructions to use twine
  [MRG] Fix AppVeyor test exit code (joblib#505)
  [MRG] turn warnings into error in the doc generation (joblib#504)
  MAINT replace py.test by pytest
  MAINT remove most warnings from documentating the doc
  Shorter error message when cache results can not be loaded. (joblib#501)
  Replace deprecated logging.warn by logging.warning
  add pypi badge to readme and move the bagdes to the top (joblib#500)
  Enable codecov on AppVeyor (joblib#497)
  Improve folder organisation for CI files (joblib#499)
  Revert flake8 version to 2.5.1
  Use Python 3.5 on AppVeyor (joblib#495)
  Fix race condition in Memory when persisting output in parallel (joblib#491)
  WindowsError should be a type under non-Windows platforms (joblib#494)
  [MRG+1] activate coverage on multiple builds (joblib#493)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants