Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the 3MN potential of Smith et al. (2015) #232

Merged
merged 27 commits into from
Mar 24, 2015
Merged

Adds the 3MN potential of Smith et al. (2015) #232

merged 27 commits into from
Mar 24, 2015

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Feb 7, 2015

To do items:

  • Implement the 3MN potential with all options
  • Raise a warning when b/Rd is outside of the approximation range
  • Figure out whether there is any clever way to append it to a list of potentials
  • glue it to C using the existing MN framework
  • Fully test the new potential:
    • passes the basic tests
    • approximates an exponential
    • Raises appropriate warnings
    • test_nemo
  • Documentation
  • Add to changelog
  • Add nemo functions and list somewhere in docs

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 13bff3c on mn3 into * on dev-v1.1*.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 13bff3c on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 13bff3c on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5ac0504 on mn3 into * on dev-v1.1*.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5ac0504 on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5ac0504 on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 333d4d3 on mn3 into * on dev-v1.1*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 333d4d3 on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5c6b9fe on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 89d6fef on mn3 into * on dev-v1.1*.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 89d6fef on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 89d6fef on mn3 into * on dev-v1.1*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 740f07f on mn3 into * on dev-v1.1*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 740f07f on mn3 into * on dev-v1.1*.

jobovy added a commit that referenced this pull request Mar 24, 2015
@jobovy
Merge pull request #232 from jobovy/mn3
1b18a1c 
Adds the 3MN potential of Smith et al. (2015)
@jobovy jobovy merged commit 1b18a1c into dev-v1.1 Mar 24, 2015
@jobovy jobovy deleted the mn3 branch March 24, 2015 16:00
@jobovy jobovy mentioned this pull request Mar 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jobovy @coveralls