Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namedtuples for internal message objects #80

Merged
merged 3 commits into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@jodal
Copy link
Owner

commented Mar 3, 2019

This is a purely internal change.

Mopidy < 3 is known to depend on the details of the old internal messaging format, so a message filter is added to upgrade any messages in the old format to the new format, while emitting a DeprecationWarning.

@jodal jodal added this to the v2.0 milestone Mar 3, 2019

@jodal jodal self-assigned this Mar 3, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 3, 2019

Codecov Report

Merging #80 into develop will increase coverage by 0.18%.
The diff coverage is 97.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
+ Coverage     94.9%   95.09%   +0.18%     
===========================================
  Files           14       14              
  Lines          569      591      +22     
===========================================
+ Hits           540      562      +22     
  Misses          29       29
Impacted Files Coverage Δ
pykka/ref.py 100% <100%> (ø) ⬆️
pykka/actor.py 96.12% <100%> (+0.77%) ⬆️
pykka/proxy.py 98.86% <100%> (ø) ⬆️
pykka/messaging.py 96.55% <95.45%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3094e4...b30c503. Read the comment docs.

@jodal jodal merged commit 0c1ef0f into develop Mar 3, 2019

12 checks passed

ci/circleci: black Your tests passed on CircleCI!
Details
ci/circleci: check-manifest Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: py27 Your tests passed on CircleCI!
Details
ci/circleci: py34 Your tests passed on CircleCI!
Details
ci/circleci: py35 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: py37 Your tests passed on CircleCI!
Details
ci/circleci: py38 Your tests passed on CircleCI!
Details
ci/circleci: pypy Your tests passed on CircleCI!
Details
ci/circleci: pypy3 Your tests passed on CircleCI!
Details

@jodal jodal deleted the message-objects branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.