fix reading of OCCIBLOB #160

Merged
merged 1 commit into from Sep 17, 2014

Conversation

Projects
None yet
4 participants
@burkostya

We do not need these deletes because node::Buffer::New accepts RandomBytesFree callback for deleting buffer by GC. fixes #92

Konstantin Burykin
fix BLOB reading
We do not need these deletes because `node::Buffer::New` accepts `RandomBytesFree` callback for deleting `buffer` by GC. fixes #92
@burkostya

This comment has been minimized.

Show comment Hide comment
@burkostya

burkostya Mar 17, 2014

Another approach will be using node::Buffer::New(buffer, bufferLength). This constructor will create copy of buffer.

Another approach will be using node::Buffer::New(buffer, bufferLength). This constructor will create copy of buffer.

@realityfilter

This comment has been minimized.

Show comment Hide comment
@realityfilter

realityfilter Jul 12, 2014

Thanks for this fix. This should be merged soon. Otherwise users may get wrong blob results of correct size without getting an error.

Thanks for this fix. This should be merged soon. Otherwise users may get wrong blob results of correct size without getting an error.

@flyth

This comment has been minimized.

Show comment Hide comment
@flyth

flyth Sep 17, 2014

Contributor

Yes, please merge this - the problem has actually been fixed before at miktam/node-oracle@ddef503 / #42 but got back in with b22b009 .

Contributor

flyth commented Sep 17, 2014

Yes, please merge this - the problem has actually been fixed before at miktam/node-oracle@ddef503 / #42 but got back in with b22b009 .

raztus added a commit that referenced this pull request Sep 17, 2014

@raztus raztus merged commit c1864a0 into joeferner:master Sep 17, 2014

@raztus

This comment has been minimized.

Show comment Hide comment
@raztus

raztus Sep 17, 2014

Collaborator

@realityfilter @flyth @burkostya Please try this again from the current master and confirm that your issue is resolved. I'd like to have some feedback before we push to npm.

Collaborator

raztus commented Sep 17, 2014

@realityfilter @flyth @burkostya Please try this again from the current master and confirm that your issue is resolved. I'd like to have some feedback before we push to npm.

@realityfilter

This comment has been minimized.

Show comment Hide comment
@realityfilter

realityfilter Sep 18, 2014

See my comment on #160. Only after applying this patch I was able to export CLOB data. I compared hashes and successfully exported some GB of data with it.

See my comment on #160. Only after applying this patch I was able to export CLOB data. I compared hashes and successfully exported some GB of data with it.

@burkostya

This comment has been minimized.

Show comment Hide comment
@burkostya

burkostya Sep 18, 2014

@raztus Can confirm. Reading from db using master works correctly.

@raztus Can confirm. Reading from db using master works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment