fix(CLOB): clob values had wrong values #198

Merged
merged 2 commits into from Sep 17, 2014

Projects

None yet

2 participants

@realityfilter

Appending to the result string now respects the read count.

realityfilter fix(CLOB): clob values had wrong values
Appending to the result string now respects the read count.
792268e
@raztus
Collaborator
raztus commented Jul 10, 2014

Would you be willing to add a unit test that demonstrates the issue?

realityfilter fix(CLOB): clob values had wrong values
Appending to the result string now respects the read count.
Fix for second code occurrence of clob transformation.
5980b35
@raztus raztus merged commit 2afb3f2 into joeferner:master Sep 17, 2014
@raztus
Collaborator
raztus commented Sep 17, 2014

@realityfilter Please try this again from the current master and confirm that your issue is resolved. I'd like to have some feedback before we push to npm.

@realityfilter

I have used this fix to export live data from oracle. To be on the safe side I calculated md5 hashes on the oracle side with LOWER(RAWTOHEX(DBMS_CRYPTO.HASH(UTL_RAW.CAST_TO_RAW(text), 1))) and compared it withe the result from this driver. With this patch applied both hashes match.

I did this for CLOBs too. Only after applying patch from #160 I was able to successfully export CLOB data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment