From 061aad51ce88e51861c32bacbaaecbd79bbdc298 Mon Sep 17 00:00:00 2001
From: joegatt <joe@joegatt.net>
Date: Sun, 8 Sep 2013 22:26:05 +0200
Subject: [PATCH] Fix user id in API call

---
 app/models/pantograph.rb   | 15 +++++++--------
 app/models/pantographer.rb |  4 +++-
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/app/models/pantograph.rb b/app/models/pantograph.rb
index 03c1d967..c173f0c6 100644
--- a/app/models/pantograph.rb
+++ b/app/models/pantograph.rb
@@ -64,20 +64,19 @@ def self.calculate_after(previous)
   def self.update_saved_timeline
     min_id = first.nil? ? 0 : first.tweet_id
     get_timeline(min_id)
-    min_id
   end
 
   private
 
   def self.get_timeline(min_id)
     authenticated_twitter_client.home_timeline(trim_user: true, min_id: min_id).each do |tweet|
-      user = Pantographer.first_or_create(twitter_user_id: tweet.user.id)
-      create(
-            body: sanitize(tweet.text),
-            external_created_at: tweet.created_at,
-            tweet_id: tweet.id,
-            pantographer_id: user.id
-          )
+    user = Pantographer.first_or_create(twitter_user_id: tweet.user.id)
+    create(
+          body: sanitize(tweet.text),
+          external_created_at: tweet.created_at,
+          tweet_id: tweet.id,
+          pantographer_id: user.id
+        )
     end
   end
 
diff --git a/app/models/pantographer.rb b/app/models/pantographer.rb
index f4018799..94d9f564 100644
--- a/app/models/pantographer.rb
+++ b/app/models/pantographer.rb
@@ -14,6 +14,8 @@ class Pantographer < ActiveRecord::Base
 
   def self.follow_followers
     client = Pantographer.authenticated_twitter_client
+    # REVIEW: Can we just get id using frinds_ids?
+    #  Can we send the array straight to follow/unfollow
     followers = client.followers(skip_status: true, include_user_entities: false).to_a
     friends = client.friends(skip_status: true, include_user_entities: false).to_a
     (friends - followers).each { |user| client.unfollow(user.id) }
@@ -23,7 +25,7 @@ def self.follow_followers
   protected
 
   def get_user_details
-    twitter_user = Pantographer.authenticated_twitter_client.user(id: twitter_user_id)
+    twitter_user = Pantographer.authenticated_twitter_client.user(twitter_user_id)
     self.twitter_screen_name = twitter_user.screen_name
     self.twitter_real_name = twitter_user.name
   end