Added Missing Keywords #110

Closed
wants to merge 2 commits into
from

Conversation

2 participants
@edyedy123

Keywords added:
optimization, speed, simplicity and security.

Hey, I am currently taking an open source class and this is my first contribution to a project.
Although this is a small change it is important to have keywords up so that the project can get more attention.

Here is a link to a pic of the lines I added(Lines 5-10)
https://gyazo.com/aebf101e13776cef2826984ddb3f3eb0

Thank you for your time.

edyedy123 added some commits Jan 27, 2017

Added relevant keywords.
Keywords added:
optimization, speed, simplicity and security.

Hey, I am currently taking an open source class and this is my first contribution to a project.
Although this is a small change it is important to have keywords up so that the project can get more attention.

Here is a link to a pic of the lines I added(Lines 5-10)
https://gyazo.com/aebf101e13776cef2826984ddb3f3eb0

Thank you for your time.
Merge pull request #1 from edyedy123/edyedy123-package.json
Keywords added:
optimization, speed, simplicity and security.

Hey, I am currently taking an open source class and this is my first contribution to a project.
Although this is a small change it is important to have keywords up so that the project can get more attention.

Here is a link to a pic of the lines I added(Lines 5-10)
https://gyazo.com/aebf101e13776cef2826984ddb3f3eb0

Thank you for your time.
@joehand

This comment has been minimized.

Show comment
Hide comment
@joehand

joehand Jan 31, 2017

Owner

Hi there, thank you for the PR and congratulations on your first PR!

Keywords are important but these seem pretty generic to me, for example security returns 15k results. Keywords including "file sharing", "dataset", "distributed" may be better.

Here is a link to a pic of the lines I added(Lines 5-10)

Thank you for the picture, but github makes it quite easy to see the diff so this is unnecessary.

Owner

joehand commented Jan 31, 2017

Hi there, thank you for the PR and congratulations on your first PR!

Keywords are important but these seem pretty generic to me, for example security returns 15k results. Keywords including "file sharing", "dataset", "distributed" may be better.

Here is a link to a pic of the lines I added(Lines 5-10)

Thank you for the picture, but github makes it quite easy to see the diff so this is unnecessary.

@joehand

This comment has been minimized.

Show comment
Hide comment
@joehand

joehand Feb 6, 2017

Owner

Hi @edyedy123, we've moved this code + repo back over to datproject/dat.

Thanks again for the PR! Feel free to open another one on that repo.

Owner

joehand commented Feb 6, 2017

Hi @edyedy123, we've moved this code + repo back over to datproject/dat.

Thanks again for the PR! Feel free to open another one on that repo.

@joehand joehand closed this Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment