Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertion description is forgotten after using extracting #920

Closed
joel-costigliola opened this issue Feb 11, 2017 · 3 comments
Closed

assertion description is forgotten after using extracting #920

joel-costigliola opened this issue Feb 11, 2017 · 3 comments
Milestone

Comments

@joel-costigliola
Copy link
Member

Summary

After using extracting the assertion information (including the description) is forgotten as a new assertion is created to check the extracted values

Example

assertThat(fellowshipOfTheRing).as("check names") 
                               .extracting("name")  
                               .contains(sauron);   

(obviously) fails as expected but check names does not appear in the error message.

@fiery-phoenix
Copy link
Contributor

fiery-phoenix commented Mar 9, 2017

It is not compatible with #918 (#955). Unless, parent assertion description is to be added before fields names.

@joel-costigliola
Copy link
Member Author

@fiery-phoenix point taken, #918 is valuable, let's try to see if it is possible to combine this and #918 without confusing users.

@joel-costigliola joel-costigliola added this to the 2.8.0 milestone Mar 26, 2017
@PascalSchumacher
Copy link
Member

This was fixed in 09c084f and 7365f84

@PascalSchumacher PascalSchumacher modified the milestones: 2.7.0, 2.8.0 May 14, 2017
PascalSchumacher added a commit to joel-costigliola/assertj that referenced this issue May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants