Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of isCloseToUtcNow #1528

Closed
wants to merge 1 commit into from
Closed

Conversation

@ngeor
Copy link
Contributor

ngeor commented Jun 17, 2019

Check List:

  • Fixes #1519
  • Unit tests : YES
  • Javadoc with a code example (API only) : YES
@joel-costigliola

This comment has been minimized.

Copy link
Owner

joel-costigliola commented Jun 23, 2019

@ngeor I have commented the PR, thanks for the work. The comments were made for LocalDateTime assertions but they also applies to OffsetDateTime assertions, I haven't duplicated them for brevity's sake.

@ngeor ngeor force-pushed the ngeor:1519 branch from 4276a35 to 3623c58 Jun 23, 2019
@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jun 23, 2019

Hi @joel-costigliola thank you for the feedback, please have another look when you find the time, it should all be fixed now.

@joel-costigliola

This comment has been minimized.

Copy link
Owner

joel-costigliola commented Jun 24, 2019

Integrated thanks @ngeor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.