New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicRobot.click doesn't do enough sanity check and has no timeout before trying to click component #177

Open
timmikk opened this Issue Feb 8, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@timmikk
Contributor

timmikk commented Feb 8, 2016

I'm currently testing software that sometimes still loads and rearranges the screen components after they are set visible. This causes my test to fails some times as in test the BasicRobot tries to click a component that has negative width. What I would like to have is a some kind of sanity check in BasicRobot's click functionality that checks that the component is visible and has some sensible size. Also there should be timeout so that the clicking doesn't fail immediately. This way test could be much more robust even in applications that don't behave optimally.

@timmikk timmikk referenced a pull request that will close this issue Feb 10, 2016

Open

Component size check and timeout for BasicRobot.click #178

@croesch

This comment has been minimized.

Show comment
Hide comment
@croesch

croesch Feb 15, 2016

Collaborator

Could you provide a code snippet of the test code? ComponentDriver does already check whether components are showing, does that help you? So instead of using robot's click method, how about using the click method of the component's fixtuer?

Collaborator

croesch commented Feb 15, 2016

Could you provide a code snippet of the test code? ComponentDriver does already check whether components are showing, does that help you? So instead of using robot's click method, how about using the click method of the component's fixtuer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment