Skip to content

add minimize button - #6

Merged
joelpurra merged 2 commits into
joelpurra:masterfrom
binki:master
Oct 6, 2018
Merged

add minimize button#6
joelpurra merged 2 commits into
joelpurra:masterfrom
binki:master

Conversation

@binki

@binki binki commented Jun 17, 2017

Copy link
Copy Markdown
Contributor

Unfortunately the minimize button causes part of the title bar to be covered.

@joelpurra joelpurra mentioned this pull request Jun 28, 2017
@joelpurra

Copy link
Copy Markdown
Owner

@binki: thanks for the pull request! As the window behavior of the X-Mouse Controls window in particular is crucial to the operation of the program, I am reluctant to accept the pull request without testing it myself. Unfortunately other programming work is getting in the way of setting up the right development environment to test it, which is why I'll have to let it rest for now. Thanks again, and sorry about not getting to yet =(

@joelpurra

Copy link
Copy Markdown
Owner

@binki: quick reply. Work keeps me busy. While I did get to setting up a new virtual machine for some "pure" system testing, I didn't get to testing this pull request yet. Sorry about that. No need to lose hope though =)

@binki

binki commented Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

@joelpurra No problem. Also, no need to use this PR when you do find time to look at #5. This PR is quite trivial and I haven’t made any attempt to make things “look good” after just setting the minimize button to display ;-).

@joelpurra
joelpurra merged commit ed3589b into joelpurra:master Oct 6, 2018
@joelpurra

Copy link
Copy Markdown
Owner

@binki: merged, many thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants