New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimize button #6

Merged
merged 2 commits into from Oct 6, 2018

Conversation

Projects
None yet
2 participants
@binki
Contributor

binki commented Jun 17, 2017

Unfortunately the minimize button causes part of the title bar to be covered.

binki added some commits Jun 17, 2017

@joelpurra joelpurra referenced this pull request Jun 28, 2017

Closed

Add minimize button #5

@joelpurra

This comment has been minimized.

Owner

joelpurra commented Jun 28, 2017

@binki: thanks for the pull request! As the window behavior of the X-Mouse Controls window in particular is crucial to the operation of the program, I am reluctant to accept the pull request without testing it myself. Unfortunately other programming work is getting in the way of setting up the right development environment to test it, which is why I'll have to let it rest for now. Thanks again, and sorry about not getting to yet =(

@joelpurra

This comment has been minimized.

Owner

joelpurra commented Aug 7, 2017

@binki: quick reply. Work keeps me busy. While I did get to setting up a new virtual machine for some "pure" system testing, I didn't get to testing this pull request yet. Sorry about that. No need to lose hope though =)

@binki

This comment has been minimized.

Contributor

binki commented Aug 7, 2017

@joelpurra No problem. Also, no need to use this PR when you do find time to look at #5. This PR is quite trivial and I haven’t made any attempt to make things “look good” after just setting the minimize button to display ;-).

@joelpurra joelpurra merged commit ed3589b into joelpurra:master Oct 6, 2018

@joelpurra

This comment has been minimized.

Owner

joelpurra commented Oct 6, 2018

@binki: merged, many thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment