Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark for ChoEtl #23

Merged
merged 4 commits into from Jan 28, 2021
Merged

Added benchmark for ChoEtl #23

merged 4 commits into from Jan 28, 2021

Conversation

JoshClose
Copy link
Contributor

No description provided.

@JoshClose JoshClose mentioned this pull request Jan 23, 2021
@joelverhagen
Copy link
Owner

Looks like this one is reading data differently than the others. From the GitHub Actions build:

 Group #1 (result JSON length = 946233):
   - Csv
   - CsvHelper
   - CsvTextFieldParser
   - Ctl_Data
   - Cursively
   - FastCsvParser
   - FluentCsv
   - HomeGrown
   - LumenWorksCsvReader
   - mgholam_fastCSV
   - Microsoft_VisualBasic_FileIO_TextFieldParser
   - NReco_Csv
   - ServiceStack_Text
   - string_Split
   - SoftCircuits_CsvParser
   - Sylvan_Data_Csv
   - TinyCsvReader
 
 Group #2 (result JSON length = 963835):
   - ChoEtl

@JoshClose
Copy link
Contributor Author

Hmm... Not sure what to do then. Do you want to include it and say it doesn't parse files correctly? I could have done something wrong in setting it up I guess, but it did make it through a benchmark run.

@jzabroski
Copy link

Could it be an encoding issue.

@JoshClose
Copy link
Contributor Author

Fixed this one.

@joelverhagen joelverhagen merged commit a9ffd65 into joelverhagen:main Jan 28, 2021
@joelverhagen
Copy link
Owner

Looks great, thanks!

@JoshClose JoshClose deleted the cho-etl branch January 28, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants