Added benchmark for CommonLibrary.NET

[JoshClose]

No description provided.

[JoshClose]

I don't get the failure locally.

[joelverhagen]

Works locally for me too. I'll merge and figured out what's up.

[joelverhagen]

Okay, it looks like the CI was running on ubuntu-latest and I presume we are both using Windows. Probably line ending issues.

[JoshClose]

Does that mean your tests need to specify the line ending? Libraries should be able to to handle any type of newline, but tests should also be consistent across platforms.

[joelverhagen]

Does that mean your tests need to specify the line ending?

Yes 😞. I had to make this change. Previously it was using Environment.NewLine which yielded \n on Ubuntu leading to the test failure.

NCsvPerf/NCsvPerf/TestData/TestData.cs

Lines 69 to 72 in f59ab5b

	// We use CR LF consistently instead of Environment.NewLine because some libraries (e.g. CommonLibrary.NET)
	// does not handled Unix-style LF gracefully.
	const string NewLine = "\r\n";
	return Encoding.UTF8.GetBytes(string.Join(NewLine, sourceLines) + NewLine);

Libraries should be able to to handle any type of newline, but tests should also be consistent across platforms.

I looked through the CommonLibrary.NET source code on CodePlex and found code detecting newline by explicitly checking for CR LF (\r then \n). This means it does not handle any type of newline.

As a side not the SEA.CommonLibrary.NET package is compiled with Debug configuration. I'm considering forking the source code onto GitHub myself and publishing my own copy with at least Release configuration and perhaps even a minimal change to handle files with just LF.

[JoshClose]

Nice. What a good open source citizen.

[joelverhagen]

Done.

GitHub | NuGet

LF is supported and it's built with Release configuration.

[JoshClose]

Awesome! In your NuGet description you might want to mention that your version supports LF and is in Release config.