added TxtCsvHelper - #32
Merged
Merged
Conversation
joelverhagen
reviewed
Jul 1, 2021
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" /> | ||
| <PackageReference Include="TxtCsvHelper" Version="1.2.8" /> |
Owner
There was a problem hiding this comment.
This is not needed since this reference will come in transitively from NCsvPerf.csproj.
Contributor
Author
|
I'm sorry, how do I include that then?
Sorry to be such a pain, like I said I'm fully self taught and I have
little experience with Github and unit testing
…On Thu, Jul 1, 2021 at 12:43 PM Joel Verhagen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In NCsvPerf.Test/NCsvPerf.Test.csproj
<#32 (comment)>:
> @@ -8,6 +8,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
+ <PackageReference Include="TxtCsvHelper" Version="1.2.8" />
This is not needed since this reference will come in transitively from
NCsvPerf.csproj.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ7PX56ZV6R4XR2VSWPZ4ZTTVTAO3ANCNFSM47VJHBJA>
.
|
Owner
No problem :). Because the NCsvPerf.Test.csproj project file references the NCsvPerf.csproj project with a project reference, all of the package references in the latter will automatically flow in to the test project. This is why you don't see any other lines in NCsvPerf.Test.csproj for the other CSV parsing libraries that are being tested. You can simply delete that line that I commented on and run |
Contributor
Author
|
Okay, it should be fixed now!
…On Thu, Jul 1, 2021 at 7:22 PM Joel Verhagen ***@***.***> wrote:
I'm sorry, how do I include that then? Sorry to be such a pain, like I
said I'm fully self taught and I have little experience with Github and
unit testing
No problem :). Because the NCsvPerf.Test.csproj project file references
the NCsvPerf.csproj project with a project reference, all of the package
references in the latter will automatically flow in to the test project.
This is why you don't see any other lines in NCsvPerf.Test.csproj for the
other CSV parsing libraries that are being tested. You can simply delete
that line that I commented on and run dotnet build again to see that it
still works.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ7PX53RF3UR4H5EMZJCNTDTVUPGHANCNFSM47VJHBJA>
.
|
Owner
|
Thanks Cameron! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new nuget package