Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CsvHelper to 20.0.0. Use CsvParser instead of CsvReader. Enable field caching. #8

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

JoshClose
Copy link
Contributor

No description provided.

@joelverhagen
Copy link
Owner

Hey @JoshClose, I guess this is the span stuff you've been playing around with? Given CsvHelper is your library, I'll trust the owner, accept this PR as is, and report whatever perf comes from it. Thanks so much!

There are a couple of other libraries mentioned in a PR and in issues so I'll try to take care of those as well before rerunning the benchmark and updating my blog post.

@joelverhagen joelverhagen merged commit 1366b8d into joelverhagen:main Jan 17, 2021
@JoshClose
Copy link
Contributor Author

Check this one out too. https://www.nuget.org/packages/SoftCircuits.CsvParser/ I started looking into integrating it, but I'm getting some sort of namespace conflict with another library.

@joelverhagen
Copy link
Owner

joelverhagen commented Jan 18, 2021

Yikes, both libraries has "CsvParser.dll". That's a problem 😂. I forked one. Thanks for the pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants