Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: joemasilotti/railsdevs.com
base: 5a90093
Choose a base ref
head repository: joemasilotti/railsdevs.com
compare: 62ceb16b8b98e8f22f116404879cae8e7d3ad2fb
Choose a head ref
  • 3 commits
  • 46 files changed
  • 2 contributors

Commits on Jan 1, 2022

  1. Build notification UI (#182)

    * Update model and prep assets
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Add controllers and views
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Add notification badge to signed in component
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Remove redirect parameter from controller
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Add unit tests
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Refactor notifications model and controllers
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Minor fixes from PR review
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Fix availability component test
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Refactor routes.rb
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Refactor notification read_at + PR review fixes
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Additional PR review tweaks
    
    Signed-off-by: Jay Clark <jay@jayeclark.dev>
    
    * Feature flag notifications UI and mark_as_read!
    
    Co-authored-by: Joe Masilotti <joe@masilotti.com>
    jayeclark and joemasilotti committed Jan 1, 2022

Commits on Jan 2, 2022

  1. Refactor notifications (#199)

    * Delete notifications when recipient is destroyed
    
    * Add conversation to Notification for easy querying
    
    * Use Heroicons bell icon
    
    * Add admin User and Message/Conversation to seeds
    
    * Get message title from notification instance
    
    * Rework read notifications routing
    
    * This always returns an association
    
    * Link directly to the notification, then redirect
    
    * Simplify queries
    
    * Rework notification dot
    
    * Rework notifications to "belong" to a User
    
    not a Developer or a Business.
    
    * Show the developer's real name when cold messaging
    
    * Not needed; we can current_user.notifications now
    
    * Mark conversation-related notifications as read
    
    * Mark ALL existing notifications as read
    
    * Feature flag marking notifications as read
    
    * /read_notifications -> /notifications/read
    
    * /notifications/read has priority
    
    to avoid conflict with /notifications/:id
    joemasilotti committed Jan 2, 2022