Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Lookbook for admin components #624

Open
3 tasks
joemasilotti opened this issue Aug 31, 2022 · 6 comments · May be fixed by #626
Open
3 tasks

Integrate Lookbook for admin components #624

joemasilotti opened this issue Aug 31, 2022 · 6 comments · May be fixed by #626
Assignees
Labels
help wanted Looking for help from the community

Comments

@joemasilotti
Copy link
Owner

joemasilotti commented Aug 31, 2022

More and more View Components have been added to the Admin:: namespace the past few weeks. I'd love to be able to preview them on their own and together as a page. This could be especially helpful for new folks to the project as they can see examples without diving into code.

A PR addressing this issue should:

  • Integrate the Lookbook gem in development
  • Add fully implemented previews for Admin::ListComponent, Admin::Tables::TableComponent, and Admin::Forms::ContainerComponent
  • Add 2-3 individual component previews

Please don't add all the component previews in this PR. This will be a pressure test of how Lookbook works, is integrated, and what we can customize. Then we can go back and add the rest when we are sure it's the right path!

Also, I'm not interested in the experimental pages feature (yet). For now the 3 "component" previews could be under a "Pages" folder.

@faqndo97
Copy link
Contributor

faqndo97 commented Aug 31, 2022

@joemasilotti i never integrated lookbook into a project, would you like that I take this one?

@joemasilotti
Copy link
Owner Author

If you're up for it then go for it!

Please post updates when you can as I'm really excited about this and want to see it live. If I don't hear back in 7 days I'll reach out and see how you're doing.

@faqndo97
Copy link
Contributor

@joemasilotti cool, thanks! I'll keep updated here and probably start some thread in twitter to document the process 🙌🏼

@joemasilotti
Copy link
Owner Author

That would be amazing – please do!

@faqndo97
Copy link
Contributor

faqndo97 commented Sep 3, 2022

@joemasilotti Small update here. I already installed the gem and documented the easiest component. Everything have been going well so far, but I needed to do a small trick with the base components of the previews that we can discuss later.

Current result:

BTW, the default route for this is /lookbook, but I'm using /docs/components, which one do you prefer? Or would you like to use a different one?

@joemasilotti
Copy link
Owner Author

Nice – awesome progress! /docs/components sounds great to me, and let's also set up a redirect from /lookbook.

I needed to do a small trick with the base components of the previews that we can discuss later.

Feel free to post a WIP PR with a comment or GitHub review comment and I can take a look. Happy to get it started earlier if the code will trickle throughout the changes.

@faqndo97 faqndo97 linked a pull request Sep 3, 2022 that will close this issue
3 tasks
@joemasilotti joemasilotti removed their assignment Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for help from the community
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants