Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly shareable URLs polish #647

Closed
3 tasks
joemasilotti opened this issue Sep 15, 2022 · 3 comments
Closed
3 tasks

Publicly shareable URLs polish #647

joemasilotti opened this issue Sep 15, 2022 · 3 comments
Assignees
Labels
good first issue Good for first time contributors help wanted Looking for help from the community

Comments

@joemasilotti
Copy link
Owner

joemasilotti commented Sep 15, 2022

The goal of this issue is to clean up the UX around #646.

A PR addressing this issue should:

  • When the “Share” button is clicked show a modal explaining how the public page works
  • A Cancel buttons closes the modal
  • A “Copy link” button copies the link to the clipboard

This issue is blocked by #646. This issue is no longer blocked.

Reminder to include a disclaimer that the developer's email address will be shared if they share their profile via this method.

@sarvaiyanidhi
Copy link
Contributor

Hi @joemasilotti I would like to work further on this issue.. can you please assign it to me?

@joemasilotti
Copy link
Owner Author

Sure thing! All yours @sarvaiyanidhi. Thanks again for all the help. :)

@joemasilotti
Copy link
Owner Author

Closed via #718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for first time contributors help wanted Looking for help from the community
Projects
Status: In progress
Development

No branches or pull requests

2 participants