Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab order and autofocus on sign in + registration screens #812

Closed
3 tasks
joemasilotti opened this issue Mar 17, 2023 · 9 comments
Closed
3 tasks

Tab order and autofocus on sign in + registration screens #812

joemasilotti opened this issue Mar 17, 2023 · 9 comments
Assignees
Labels
good first issue Good for first time contributors help wanted Looking for help from the community $25 bounty

Comments

@joemasilotti
Copy link
Owner

I noticed today that the the sign in and registration screens don't have some common UX affordances. I'd like to fix that.

A PR addressing this issue should:

  • Set the tab order on the sign in screen to email then password then forgot password
  • Set the tab order on the registration screen to email then password then password confirmation (if it isn't already)
  • Autofocus on the email field for both of these forms
@joemasilotti joemasilotti added help wanted Looking for help from the community good first issue Good for first time contributors $25 bounty labels Mar 17, 2023
@JuzerShakir
Copy link
Contributor

I would like to try this out!

@joemasilotti
Copy link
Owner Author

Thanks for the offer! But I'd prefer if folks only had one outstanding issue at a time. You are welcome to start work on this once #806 is complete and if no one else has claimed it.

@aj-abhishek-jadav
Copy link
Contributor

@joemasilotti Can i have a go for this?

@joemasilotti
Copy link
Owner Author

Sure thing! All yours @aj-abhishek-jadav.

@aj-abhishek-jadav
Copy link
Contributor

Thanks @joemasilotti for giving me opportunity 👍

@JuzerShakir
Copy link
Contributor

All the best @aj-abhishek-jadav 👍

@aj-abhishek-jadav
Copy link
Contributor

aj-abhishek-jadav commented Mar 18, 2023

Hi @joemasilotti,

  • shall i add autofocus on Forgot Password page's email field?
    image
  • And on Resend Confirmation Instruction Page's email field?
    image

@joemasilotti
Copy link
Owner Author

Yes please to both!

@joemasilotti
Copy link
Owner Author

Closed via #816.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for first time contributors help wanted Looking for help from the community $25 bounty
Projects
None yet
Development

No branches or pull requests

3 participants