Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer vs. business #125

Merged
merged 21 commits into from Nov 30, 2021
Merged

Developer vs. business #125

merged 21 commits into from Nov 30, 2021

Conversation

joemasilotti
Copy link
Owner

@joemasilotti joemasilotti commented Nov 23, 2021

This PR closes #124.

  • Redesign header to work with more user-focused links
  • Redirect to /roles/new after signing up
  • If a developer, redirect to /developers/new
  • If a business, redirect to /clients/new
    • Add business form
  • Add link to business profile in dropdown
  • Update avatar image in nav bar
  • Refactor AvatarComponent naming to be generic to Developer and Business.

Screenshots

image

image

image

image

image

Business flow

image

image

PR checklist

  • Your code contains tests relevant for code you modified
  • All new and existing tests are passing
  • You have linted the project bundle exec standardrb --fix

@joemasilotti joemasilotti changed the title Developer vs. client Developer vs. business Nov 27, 2021
@joemasilotti joemasilotti marked this pull request as ready for review November 29, 2021 23:33
@joemasilotti
Copy link
Owner Author

This is feature-complete, but I want to sleep on it before merging. My big open question is if this should all be behind a feature flag.

@joemasilotti joemasilotti merged commit 7d3e487 into main Nov 30, 2021
5 checks passed
@joemasilotti joemasilotti deleted the developer-vs-client branch November 30, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After signing up, a user can identify as a developer or business
2 participants