New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging #132
Messaging #132
Conversation
85d1d7a
to
5024c6d
Compare
|
CC @jacobdaddario and @Tonksthebear because you both expressed interest in these features. Would love to hear your thoughts or quick PR review before I merge. |
|
Hey! Sorry I've been occupied with some other stuff recently. I'll take a look this evening! |
|
Hey, I have a lot on my plate this week. I might be able to hop on and take a look, but I just wanted to acknowledge your message and give you a heads up to not wait on me. I will definitely take a look if I get a chance though! |
|
Hey, sorry for not getting to this yesterday. Life has still been kicking my butt. I'll attempt to get to it tonight. |
|
Looks good to me! I think there's things I would have approached a different way, but the logic you laid out all seems to make sense. |
This PR addresses #120, #121, and #122. I tried to split this into 3 PRs, but I ended up rewriting so much of #130 that I don't think it is worth keeping them separate anymore.
All of the refactors from #130 have been pulled in, so check out that PR for details on the pundit changes.
I ended up simplifying the routes a ton to get the base functionality working. Instead of trying to nest conversations inside of developers, the route is more Rails-y:
/conversations/:id. This helps clean up the controller logic a ton.On top of that, to ensure only a
Businesscan initiate a conversation,ColdMessagesControllerwas added. This includes the logic for kicking off that first message and redirecting to an existing conversation if one exists.Room for improvement / future PRs
Messageform at the bottom of the conversation page could be Turbo-ifiedBusinesspage is very barebones, and could use another design passBusinesswants to add, tooPull request checklist
bundle exec standardrb --fixbundle exec erblint --lint-all --autocorrectCloses #120, #121, and #122.