Add time zone to developer profile #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there's a merge conflict in the scheme file and standard is complaining about some formatting. |
caseyjenks
force-pushed
the
feature/add-timezone
branch
2 times, most recently
from
11d806b
to
6cf729f
Compare
Doh, updated |
joemasilotti
requested changes
Dec 8, 2021
caseyjenks
force-pushed
the
feature/add-timezone
branch
from
6cf729f
to
38ac834
Compare
caseyjenks
force-pushed
the
feature/add-timezone
branch
from
38ac834
to
8070115
Compare
joemasilotti
approved these changes
Dec 14, 2021
|
Looks great, thanks @caseyjenks! I made one change to ensure lines don't get rendered between empty sections. I'll merge when CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Purpose
Adds timezone field to developers
Approach
time_zonetodeveloperstable.time_zone_selectfor the time zone dropdownScreenshot