Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require view_component/engine in Gemfile #141

Merged
merged 1 commit into from Dec 9, 2021

Conversation

danieldpence
Copy link
Contributor

One more for ya 😄
Closes #131.
Reference: ViewComponent/view_component#560

Pull request checklist

  • Your code contains tests relevant for code you modified
  • All new and existing tests are passing
  • You have linted the project with bundle exec standardrb --fix
  • You have linted the project with bundle exec erblint --lint-all --autocorrect
  • You have linted the project with bundle exec i18n-tasks health

@joemasilotti
Copy link
Owner

Amazing! Great debugging here. This has been driving me crazy 😆

@joemasilotti joemasilotti merged commit 398d380 into joemasilotti:main Dec 9, 2021
5 checks passed
joemasilotti added a commit to joemasilotti/view_component that referenced this pull request Dec 9, 2021
Without this, changes applied to an HTML file won't be reflected in dev until you restart the server or touch a `.rb` file.

ViewComponent#560 (comment)
joemasilotti/railsdevs.com#141
joemasilotti/railsdevs.com#131
@joemasilotti
Copy link
Owner

FYI: this was fixed in v2.46!

ViewComponent/view_component#1189 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Components aren't reloaded if only HTML is changed (in development)
2 participants