Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Business subscriptions #168

Merged
merged 22 commits into from Dec 21, 2021
Merged

Business subscriptions #168

merged 22 commits into from Dec 21, 2021
+262 −17

Conversation

joemasilotti
Copy link
Owner

@joemasilotti joemasilotti commented Dec 19, 2021 •
edited

This PR addresses #158. It builds on #167 (now closed) to use Pay to manage payments (via Stripe).

TODOs

  • Add instructions to README on creating Stripe account and adding private keys
  • In tests, mock Stripe (or Pay?), not BusinessSubscriptionCheckout
  • Add tests for BusinessSubscriptionCheckout

Pull request checklist

  • Your code contains tests relevant for code you modified
  • You have linted and tested the project with bin/check

@joemasilotti joemasilotti mentioned this pull request Dec 19, 2021
Closed
2 tasks
@joemasilotti joemasilotti marked this pull request as ready for review December 20, 2021 02:27
@joemasilotti joemasilotti merged commit 8a62396 into main Dec 21, 2021
5 checks passed
@joemasilotti joemasilotti deleted the business-subscription branch December 21, 2021 13:02
@joemasilotti joemasilotti mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joemasilotti