Open source/analytics links now to be opened in a new tab #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salochara
changed the title
salochara
changed the title
salochara
changed the title
joemasilotti
requested changes
Dec 21, 2021
In order to avoid having the user off-site, open source and open analytics links form the navbar are now to be opened in a new tab
salochara
force-pushed
the
chore/nav-links-open-in-new-tab
branch
from
2e00ead
to
b9b4b6e
Compare
joemasilotti
approved these changes
Dec 21, 2021
|
And merged. Thanks so much for the PR. Welcome to the community, both on railsdevs and OSS! Honored to maintain the repository of your first contribution. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I started to play around with this project. I figured this would be a good start for contributing!
It's a simple change, although I believe it's benefitial for the application.
Open source and open analytics links are now to be opened in a new tab so we don't take users off-site.
Also, added .idea directory to .gitignore for people (myself included😁 ) working in RubyMine
P.S.🚀
This would be my first contributon to OSS
I'm just starting my carreer as a RoR developer and have been following this project for a bit now. Would love to keep on contributing!
Pull request checklist
bin/check