Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations #264

Merged
merged 57 commits into from Jan 30, 2022
Merged

Translations #264

merged 57 commits into from Jan 30, 2022

Conversation

joemasilotti
Copy link
Owner

@joemasilotti joemasilotti commented Jan 29, 2022 •
edited

This PR combines the work done in #256 with the Spanish translations in #240. I had to rework some of the Devise translations and made a few design changes. Everything seems to be working fine, including CI.

The problem is that tests seem to be failing sporadicly. I can't nail down what is going on but I'm assuming it has to do with setting the locale. If anyone has any ideas of what's going on (CC @hungmi and @salochara) I'd love some help!

Closes #219, #256, and #240.

Pull request checklist

  • Your code contains tests relevant for code you modified
  • You have linted and tested the project with bin/check

salochara and others added 30 commits January 14, 2022 20:45
@salochara
Add missing call to translation in form partial
312e4a0
@salochara
Add Spanish translations
855ed4f
@salochara
Add config for using :es translation
ba5de7b
@salochara
Only check for :en locale health in bin/check script
49c1981
@hungmi
code from #240
5b71c13
@hungmi
Enable railsdevs.com/locale/* routes
fa8fc08
@hungmi
All link helpers will set current locale automatically
3468004
@hungmi
Add Chinese Traditional translations of nav links for testing purpose
43b2701
@hungmi
add links in footer so that we can change to other locales
bcfc1e9
@hungmi
Show current lang in <html>
cb3fca5
@hungmi
Add locale in default url options when test
4a9189d
@hungmi
Explicitly set :id in url helpers
f006466
@hungmi
Make devise routes include locale
9da33ff
@hungmi
add alternate page links in <head>
5f659ac
@hungmi
test alternate page links in <head>
27ff9a0
@hungmi
Use before_action callback to set locale to ensure I18n.locale is set…
1d4962b 
… during integration tests
@hungmi
add switch locale test
7959fea
@hungmi
bin/check fix
d6e21c9
@hungmi
add aria labels
fc88dfe
@hungmi
Add notes about the language key in translations
287bff0
@hungmi
only translated lines in zh-TW file
61000c8 
remove comment in en.yml
@hungmi
fix suggestion
fdcf0fc
@hungmi
remove Stripe and admin out of locale scope
7ce5fa7
@hungmi
Set default locale to nil for url helpers in routes.rb
cf16deb
@hungmi
No need to pass resource id explicitly
22d958b
@hungmi
Fix a wrong test assertion
4987e6b
@hungmi
Switch language links now include all url params. Avoid errors like u…
7f024b1 
…npermitted params :id. And it won't drop :sort, :time_zone params in /developers.
@hungmi
Avoid passing default locale to urls
c6b2deb
@hungmi
Change the key of language name of the locale file
829bcef
@hungmi
Alternate page links in <head> should not show default locale
addffb1
hungmi and others added 15 commits January 26, 2022 22:50
@hungmi
Revert "Revert "No need to pass resource id explicitly""
dfeb123 
This reverts commit f53d377.
@hungmi
Set default_url_options for `include Rails.application.routes.url_hel…
691b927 
…pers`
@hungmi
Remove duplicated resolve_locale helper
e2b839f
@hungmi
Refactor default url options setting to a module
41194c6
@hungmi
Add en to the the i18n-tasks step in CI.
222cf80
@hungmi @joemasilotti
Update app/lib/url_helpers_with_default_url_options.rb
699a6dd 
Co-authored-by: Joe Masilotti <joe@masilotti.com>
@hungmi @joemasilotti
Update app/notifications/new_message_notification.rb
d9e061a 
Co-authored-by: Joe Masilotti <joe@masilotti.com>
@hungmi @joemasilotti
Update app/controllers/application_controller.rb
ed072ee 
Co-authored-by: Joe Masilotti <joe@masilotti.com>
@hungmi
std fix
1563b36
@hungmi
Add default_url_options in production environment
0f6ba17
@joemasilotti
Merge branch 'add-i18n-basics' into translations
1b10b06
@joemasilotti
Merge branch 'feature/add-spanish-translations' into translations
e3c94c5
@joemasilotti
Show all locales, including current
314887b
@joemasilotti
Add language name for Spanish
45b047c
@joemasilotti
Move non-Devise translations out; generate Devise
be46c42
@joemasilotti
Copy link
Owner Author

Ah, perfect! CI failed and it looks like it's because the locale is still set to Spanish for some reason. I think the before_action is messing things up – maybe it needs to be reset under test?

@gmmcal gmmcal mentioned this pull request Jan 29, 2022
Closed
gmmcal
gmmcal reviewed Jan 29, 2022
View reviewed changes
app/views/shared/_alternate_page_links.html.erb Outdated Show resolved Hide resolved
test/integration/switch_locale_test.rb Outdated Show resolved Hide resolved
test/integration/switch_locale_test.rb Outdated Show resolved Hide resolved
test/integration/switch_locale_test.rb Outdated Show resolved Hide resolved
@joemasilotti
Copy link
Owner Author

Thanks for the review and help @gmmcal and @hungmi!

@joemasilotti joemasilotti merged commit 9be617a into main Jan 30, 2022
5 checks passed
@joemasilotti joemasilotti deleted the translations branch January 30, 2022 00:34
This was referenced Jan 30, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmcal gmmcal gmmcal left review comments

@hungmi hungmi hungmi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translations?
4 participants
@joemasilotti @gmmcal @hungmi @salochara